Dominic Gannaway
Dominic Gannaway
You should also add `__styles` to the `element_prototype` in `operations.js`
We should be memoising the `isDarkColor()` call into a derived like we do in other places.
Rather than passing around `date` as a prop, you can instead pass around a class instance where you can control the things you care about. You shouldn't be using effects...
You don't need effects, you can just use objects like mentioned above – or create your own proxied object. However, given you want a `SvelteDate` you can also model this...
Looks like this was a regression caused by https://github.com/sveltejs/svelte/pull/14269.
I think we also want to untrack it otherwise it will fire for every change within, which is now how debug tags work.
> I'm not used to @debug, but the docs say that it's fire on every change : Not for deep state though, `@debug` isn't designed to do that, `$inspect` is...
What I mean is that we probably want to `untrack` in legacy mode, and in runes mode we don't need the untrack. Otherwise this might cause unexpected things happening in...
> Another more general possibility for static subtrees: We could do `template(() => '
> I'm not talking about doing it in the general case, only when we detect there's static-but-possibly-different-between-instances variables referenced. Doing innerHTML once instead of clone + walk + mutate might...