Dominic Gannaway

Results 318 comments of Dominic Gannaway

One thing we could do here is detect a custom-element as the parent at compile time and insert different DOM traversal methods that _allow_ for things like `` elements that...

I still believe my post above should resolve this.

@Leonidaz `unsafe` is for deriveds or template expressions only. You could always mutate state inside effects. > untrack is just fixed - and now it only prevents subscriptions during signal...

> Adjacent to #12441 I'm not sure it is at all. You definitely don't want to be updating the UI with `Date.now()` every frame, that's going to put a lot...

@gyzerok I think you should be able to safely switch to `unsafe` there and it should work as it does now. You'd have to confirm first, but you can try...

@gyzerok Looks like you'll need an `untrack` in there too with the `unsafe` if you're reading state you've created locally in a derived.

> More generally, would there be a way to automatically detect that something is an unsafe mutation and put it in the respective category, without the user having to think...

> Since there is now a variable that is changed through untrack (instead of just clearing the active reaction), we could just check if untrack is currently running when $.set...

> Yes, in the example you gave, it would compile to $.update(count), which uses $.set under the hood. If $.set were to be called in untrack, it should warn, since...

> Joking aside...what id we also check if the active_reaction is an effect and only warn if it's not? You can also mutate state when `active_reaction` is `null` and we...