TrixiParticles.jl icon indicating copy to clipboard operation
TrixiParticles.jl copied to clipboard

Add LaguerreGaussKernel

Open svchb opened this issue 3 months ago • 4 comments

In my quick testing this didn't show the claimed accuracy improvement vs Wendland and Quintic.

svchb avatar Sep 04 '25 08:09 svchb

Codecov Report

:x: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 89.59%. Comparing base (f8adb77) to head (bf4d3fe). :warning: Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/general/smoothing_kernels.jl 85.00% 3 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
- Coverage   89.60%   89.59%   -0.02%     
==========================================
  Files         120      120              
  Lines        8598     8618      +20     
==========================================
+ Hits         7704     7721      +17     
- Misses        894      897       +3     
Flag Coverage Δ
total 89.59% <85.00%> (-0.02%) :arrow_down:
unit 64.86% <85.00%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 04 '25 08:09 codecov[bot]

The normal smoothing kernel test that we have doesn't work here since the truncation error is too large.

svchb avatar Sep 04 '25 08:09 svchb

The normal smoothing kernel test that we have doesn't work here since the truncation error is too large.

The Gauss kernel is also truncated. Why can't you run the same tests for this kernel?

efaulhaber avatar Sep 26 '25 16:09 efaulhaber

The normal smoothing kernel test that we have doesn't work here since the truncation error is too large.

The Gauss kernel is also truncated. Why can't you run the same tests for this kernel?

I can but the errors seem to be unreasonable because they are larger than 1.

svchb avatar Sep 26 '25 16:09 svchb

/run-gpu-tests

svchb avatar Dec 03 '25 14:12 svchb

/run-gpu-tests

svchb avatar Dec 04 '25 13:12 svchb