TrixiParticles.jl
TrixiParticles.jl copied to clipboard
Add LaguerreGaussKernel
In my quick testing this didn't show the claimed accuracy improvement vs Wendland and Quintic.
Codecov Report
:x: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 89.59%. Comparing base (f8adb77) to head (bf4d3fe).
:warning: Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/general/smoothing_kernels.jl | 85.00% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #893 +/- ##
==========================================
- Coverage 89.60% 89.59% -0.02%
==========================================
Files 120 120
Lines 8598 8618 +20
==========================================
+ Hits 7704 7721 +17
- Misses 894 897 +3
| Flag | Coverage Δ | |
|---|---|---|
| total | 89.59% <85.00%> (-0.02%) |
:arrow_down: |
| unit | 64.86% <85.00%> (+0.04%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
The normal smoothing kernel test that we have doesn't work here since the truncation error is too large.
The normal smoothing kernel test that we have doesn't work here since the truncation error is too large.
The Gauss kernel is also truncated. Why can't you run the same tests for this kernel?
The normal smoothing kernel test that we have doesn't work here since the truncation error is too large.
The Gauss kernel is also truncated. Why can't you run the same tests for this kernel?
I can but the errors seem to be unreasonable because they are larger than 1.
/run-gpu-tests
/run-gpu-tests