P4est.jl icon indicating copy to clipboard operation
P4est.jl copied to clipboard

Published 20 hours ago • verified publisher icon trixi-framework

Update p4est JLL package to use v2.8.5

Open sloede opened this issue 2 years ago • 3 comments

p4est v2.8.5 was just released. It would be great if we could update the Yggdrasil recipe (and subsequently the JLL package) to use that version as well.

Note: the release tarball is named p4est-2.8.5.5-9ddbb.tar.gz on https://github.com/p4est/p4est.github.io/tree/master/release/, but I think this is still considered to be "p4est v2.8.5" (please correct me if I am wrong, @cburstedde).

sloede avatar Mar 30 '23 13:03 sloede

Cool! Please note that P4EST_QMAXLEVEL is valid for all quadrant operations except for set_morton and linear_id, for which P4EST_OLD_QMAXLEVEL is the limit. We have added 128 bit alternatives of the latter. The question becomes, shall the linear index type be generally promoted to 128 bit, or shall we reduce the level for set_morton and linear_id?

cburstedde avatar Mar 30 '23 18:03 cburstedde

Thanks for the heads up!

x-ref: https://github.com/DLR-AMR/t8code/issues/498

sloede avatar Mar 31 '23 04:03 sloede

Let's wait until the issue with the .la files is sorted out before updating the JLL package.

x-ref: https://github.com/DLR-AMR/t8code/issues/496#issuecomment-1492264090

sloede avatar Apr 01 '23 04:04 sloede