Trivikram Kamat comments

Results 388 comments of


                                            Trivikram Kamat

Replace unused maxRetries with maxAttempts

The internal utility `providerConfigFromInit` is called from: * `fromContainerMetadata` https://github.com/smithy-lang/smithy-typescript/blob/86862eab5e8b26520a2a3e9914d24a9ab5a98270/packages/credential-provider-imds/src/fromContainerMetadata.ts#L31 * `getInstanceMetadataProvider` https://github.com/smithy-lang/smithy-typescript/blob/86862eab5e8b26520a2a3e9914d24a9ab5a98270/packages/credential-provider-imds/src/fromInstanceMetadata.ts#L37 These utilities are further called from other providers or re-exported, like: * `remoteProvider` https://github.com/aws/aws-sdk-js-v3/blob/ac98acca73a3caf30ab802be9594bcc5ad0a0a8e/packages/credential-provider-node/src/remoteProvider.ts#L24 * `resolveCredentialSource` https://github.com/aws/aws-sdk-js-v3/blob/ac98acca73a3caf30ab802be9594bcc5ad0a0a8e/packages/credential-provider-ini/src/resolveCredentialSource.ts#L24-L29...

Replace `mkdirp` with `fs.mkdirSync(path, { recursive: true })`

Fixed in https://github.com/facebook/react-native/pull/46388

Use NODEJS_20_X in use cases and patterns

> The change is now in the repo Added in https://github.com/awslabs/aws-solutions-constructs/pull/1141

Downloads stats are off

> @trivikr maybe could you take a look? Sure. I created access request at https://github.com/nodejs/build/issues/3760, and shared the email address of my Google account as a Slack DM with @targos

Downloads stats are off

Direct link for viewing April stats: https://storage.googleapis.com/access-logs-summaries-nodejs/?marker=nodejs.org-access.log.20240331.json Verified that the access logs are missing for the dates, as mentioned in the description https://github.com/nodejs/build/issues/3697#issue-2275044074 above. Screenshot

Downloads stats are off

As per the source code, it looks like the contents of the filename are not a valid JSON https://github.com/nodejs/build/blob/437f7e389f71e9cf10c082694fb6ddfc5c655500/ansible/roles/metrics/files/process-cloudflare/process-cloudflare.js#L142-L164

Downloads stats are off

Example log which throws error ```console BUCKET cloudflare-logs-nodejs FILENAME 20240618/20240618T225603Z_20240618T225716Z_da79c9d1.log.gz PROCESSEDFILENAME 20240618/20240618T225603Z_20240618T225716Z INSIDE CREATE PIPELINE String length: 21570831 Array Length: 44744 SyntaxError: Unexpected end of JSON input ``` Direct link...