Trivikram Kamat
Trivikram Kamat
Two tests are failing ```console [test:ember] not ok 54 Chrome 121.0 - [513 ms] - Object Inspector: Date fields are editable [test:ember] --- [test:ember] actual: > [test:ember] 0 [test:ember] expected:...
The failing tests: * Date fields are editable: https://github.com/emberjs/ember-inspector/blob/528d7b6ddb84d34e08f7a04ec35889aae6e0a336/tests/acceptance/object-inspector-test.js#L858-L939 * Errors are correctly displayed: https://github.com/emberjs/ember-inspector/blob/528d7b6ddb84d34e08f7a04ec35889aae6e0a336/tests/acceptance/object-inspector-test.js#L941-L982 I'm not sure why removal of unused aws-sdk should fail these tests.
> Maybe if you only do pnpm uninstall ? I used pnpm uninstall to remove the dependency, and force pushed. Can you restart CI?
The CI is successful. Is this good to merge?
AWS SDK for JavaScript v2 will enter maintenance mode on September 8, 2024 and reach end-of-support on September 8, 2025. For more information, check blog post at https://a.co/cUPnyil
The README points out that Serverless V4 is in Beta. Since Serverless V3 was released in Jan'22. The AWS SDK for JavaScript v3 migration should ideally be considered before RC...
Do comment if I can post experimental PR targeting specific files, which could be easy to review and possibly merge. For example, I can post a PR just targeting `ecs`...
Example feature request learned from this PR https://github.com/awslabs/aws-sdk-js-codemod/issues/663
> Seems like the next step is to add the missing dependencies to package.json and see if the changes actually work? Yes. But this PR didn't change all the APIs...
Hey @reobin, anything else needed for review/merge of this PR? I've rebased from main branch, and update JS SDK v3 versions.