charts
charts copied to clipboard
Add missing HTTPS configs
While trying to follow the official instructions for TLS/HTTPS, I realised that a lot of the required flags in config.properties for the coordinator were not yet implemented.
This PR attempts to implement them to the best of my knowledge. This is my very first open-source contribution, so if I did something wrong I am happy to receive feedback and fix my mistakes / convention breaks accordingly.
The following changes were made:
secretMountswas incorrectly implemented: Indeployment-coordinator.yaml, theinitContainersclause was incorrectly in the middle of thevolumesclause, interrupting the place where thesecretMountswould be added. I've fixed this to permit correct volume addition for certificates which I assume would be mounted using this mechanism.keystore.keystorePasswordwas previously not implemented to support keystores with passwords.keystore.keymanagerPasswordwas similarly missing.- Added support for the
allowInsecureOverHttpflag.
Edit: Would also like some help on getting around the CLA checks. I've submitted my signed CLA a few days ago, and signed my commits with my email using git rebase --signoff HEAD~2 after setting my email in my git client, but still getting the error.
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Darrick Lau. This is most likely caused by a git client misconfiguration; please make sure to:
- check if your git client is configured with an email to sign commits
git config --list | grep email - If not, set it up using
git config --global user.email [email protected] - Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Darrick Lau. This is most likely caused by a git client misconfiguration; please make sure to:
- check if your git client is configured with an email to sign commits
git config --list | grep email - If not, set it up using
git config --global user.email [email protected] - Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
@cla-bot check
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Darrick Lau. This is most likely caused by a git client misconfiguration; please make sure to:
- check if your git client is configured with an email to sign commits
git config --list | grep email - If not, set it up using
git config --global user.email [email protected] - Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
The cla-bot has been summoned, and re-checked this pull request!
Hi! We were about to embark on making similar changes to the chart but stumbled upon the PR. Any chance someone can merge this?
Yep. I'm happy to integrate changes if I get some feedback. Also, some help on how to appease the cla-bot would be appreciated. I've signed my commits, but it's still complaining.
I'm having some problems when trying have an https connection to my cluster as well, how did you managed to do it, can you give me some guidance in it please?
Adding the missing properties is a good change, but this PR is abandoned, so I'm closing it.