charts icon indicating copy to clipboard operation
charts copied to clipboard

Conflicts in service discovery caused by new worker service sharing the same annotations as coordinator

Open rotem-ad opened this issue 11 months ago • 0 comments

Ran into this issue after upgrading to the latest Trino chart version.

We rely on K8s service annotations to discover services using HashiCorp Consul - See Service Sync for Consul on Kubernetes. Particularly, we use service annotations to discover Trino coordinator service.

This change in PR https://github.com/trinodb/charts/pull/227 made the new worker service share the exact same annotations as the coordinator service. This affected our service discovery system, causing it to register both coordinator and worker nodes as coordinators.

Can we please support setting service annotations separately for each service?

Thanks

rotem-ad avatar Dec 02 '24 08:12 rotem-ad