charts icon indicating copy to clipboard operation
charts copied to clipboard

Add support to jmx metrics

Open heitorrbarros opened this issue 1 year ago • 21 comments

Hi!

I'm adding support to jmx metrics. It's usefull for capture metrics and build some monitoring system.

heitorrbarros avatar Mar 15 '24 20:03 heitorrbarros

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Mar 15 '24 20:03 cla-bot[bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Mar 20 '24 16:03 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Mar 20 '24 16:03 cla-bot[bot]

@cla-bot check

heitorrbarros avatar Mar 22 '24 12:03 heitorrbarros

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Mar 22 '24 12:03 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Mar 22 '24 12:03 cla-bot[bot]

@cla-bot check

heitorrbarros avatar Mar 25 '24 12:03 heitorrbarros

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Mar 25 '24 12:03 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Mar 25 '24 12:03 cla-bot[bot]

@cla-bot check

heitorrbarros avatar Mar 27 '24 12:03 heitorrbarros

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Mar 27 '24 12:03 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Mar 27 '24 12:03 cla-bot[bot]

@cla-bot check

heitorrbarros avatar Apr 09 '24 16:04 heitorrbarros

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Apr 09 '24 16:04 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Apr 09 '24 16:04 cla-bot[bot]

@cla-bot check

heitorrbarros avatar Apr 16 '24 11:04 heitorrbarros

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Apr 16 '24 11:04 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Apr 16 '24 11:04 cla-bot[bot]

@cla-bot check

heitorrbarros avatar Apr 19 '24 12:04 heitorrbarros

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Apr 19 '24 12:04 cla-bot[bot]

@heitorrbarros please rebase and add a test, similar to https://github.com/trinodb/charts/blob/main/charts/trino/templates/tests/test-connection.yaml, that would check if the JMX metrics can be queried, when enabled. Enable them in https://github.com/trinodb/charts/blob/main/test-values.yaml

nineinchnick avatar May 22 '24 07:05 nineinchnick