charts icon indicating copy to clipboard operation
charts copied to clipboard

Support service annotations

Open p5 opened this issue 1 year ago • 9 comments

Enables the user to add annotations for the service resource so it can be integrated with load balancers and others.

This is a similar PR to https://github.com/trinodb/charts/pull/54 and aims to resolve the long-standing issue https://github.com/trinodb/trino/issues/13085, however as the PR hasn't had any progress in almost a year, trying to push through separately.

p5 avatar Feb 15 '24 00:02 p5

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Feb 15 '24 00:02 cla-bot[bot]

Submitted the CLA. Waiting for someone to check it

p5 avatar Feb 15 '24 00:02 p5

@cla-bot check

p5 avatar Mar 03 '24 12:03 p5

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Mar 03 '24 12:03 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Mar 03 '24 12:03 cla-bot[bot]

@cla-bot check

p5 avatar Mar 05 '24 02:03 p5

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Mar 05 '24 02:03 cla-bot[bot]

Would be awesome to have this merged

ArnArm avatar Apr 24 '24 11:04 ArnArm

@p5 please rebase, and I'll review once the new tests pass in the CI.

nineinchnick avatar May 22 '24 07:05 nineinchnick