charts icon indicating copy to clipboard operation
charts copied to clipboard

Fix Server.ExtraConfig indentation

Open ulfox opened this issue 2 years ago • 2 comments

Switch workerExtraConfig indentation to 2 Switch coordinatorExtraConfig indentation to 2

Before

config.properties: |
coordinator=true
node-scheduler.include-coordinator=false
http-server.http.port=8080
query.max-memory=4GB
query.max-memory-per-node=1GB
discovery.uri=http://localhost:8080
  someKey=someValue

After

config.properties: |
coordinator=true
node-scheduler.include-coordinator=false
http-server.http.port=8080
query.max-memory=4GB
query.max-memory-per-node=1GB
discovery.uri=http://localhost:8080
someKey=someValue

ulfox avatar Oct 03 '23 15:10 ulfox

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

cla-bot[bot] avatar Oct 03 '23 15:10 cla-bot[bot]

What does that actually fix? Indent of 4 is perfectly valid as well as far as I am concerned.

mosabua avatar Oct 11 '23 16:10 mosabua

@cla-bot check

nineinchnick avatar May 18 '24 15:05 nineinchnick

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Christos Kotsis. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar May 18 '24 15:05 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar May 18 '24 15:05 cla-bot[bot]

This is a valid fix:

% helm template trino charts/trino --set server.coordinatorExtraConfig=aa | grep -B8 aa 

  config.properties: |
    coordinator=true
    node-scheduler.include-coordinator=false
    http-server.http.port=8080
    query.max-memory=4GB
    query.max-memory-per-node=1GB
    discovery.uri=http://localhost:8080
      aa

nineinchnick avatar May 18 '24 15:05 nineinchnick

Fixed in 10e2060e0b6d75a4cad412a464f5da18ad30b0a7

nineinchnick avatar May 22 '24 07:05 nineinchnick