SecureXPC icon indicating copy to clipboard operation
SecureXPC copied to clipboard

Clear thread-local even if an error is thrown

Open amomchilov opened this issue 10 months ago • 0 comments
trafficstars

If the operation() throws an error, this clean-up won't happen.

Since this thread-local will stick around, subsequent calls to ClientIdentity.current will be incorrect. This would let effectiveUserID/effectivegroupID/code be called and return stale values, rather than fatalError()ing as intended.

I can't think of any immediate way to exploit this, but it's still best to just always clean it up.

amomchilov avatar Jan 23 '25 02:01 amomchilov