oauth2-bundle icon indicating copy to clipboard operation
oauth2-bundle copied to clipboard

Fix deprecation notifications since SF 5.1

Open ricohumme opened this issue 4 years ago • 3 comments
trafficstars

symfony/dependency-injection states deprecated tags in configurations should have the package name and the version the deprecation started. This PR will fix that issue

ricohumme avatar Sep 02 '21 13:09 ricohumme

Codecov Report

Merging #287 (d702614) into master (09462b1) will decrease coverage by 0.10%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #287      +/-   ##
============================================
- Coverage     92.54%   92.43%   -0.11%     
  Complexity      438      438              
============================================
  Files            65       61       -4     
  Lines          1555     1521      -34     
============================================
- Hits           1439     1406      -33     
+ Misses          116      115       -1     
Impacted Files Coverage Δ
League/Entity/Client.php 60.00% <0.00%> (-6.67%) :arrow_down:
Command/ListClientsCommand.php 96.72% <0.00%> (-0.30%) :arrow_down:
Command/UpdateClientCommand.php 96.22% <0.00%> (-0.21%) :arrow_down:
League/Entity/Scope.php 100.00% <0.00%> (ø)
Converter/ScopeConverter.php 100.00% <0.00%> (ø)
Command/CreateClientCommand.php 100.00% <0.00%> (ø)
DependencyInjection/Configuration.php 100.00% <0.00%> (ø)
Manager/InMemory/AccessTokenManager.php 100.00% <0.00%> (ø)
Manager/InMemory/RefreshTokenManager.php 100.00% <0.00%> (ø)
Manager/InMemory/AuthorizationCodeManager.php 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09462b1...d702614. Read the comment docs.

codecov-commenter avatar Sep 02 '21 13:09 codecov-commenter

@X-Coder264 fyi these test failures are not due to my contribution. Could this be merged as the impact is low code-wise, but highly on the deprecation logs in the application for users working with SF 5.1+ Thank you in advance!

ricohumme avatar Sep 02 '21 13:09 ricohumme

@ricohumme Some builds fail due to some message changes which were recently made in league/oauth2-server package. But some builds fail due to this change as IIRC this change is not compatible with Symfony 4.4 and 5.0 which we still support on the master branch.

X-Coder264 avatar Sep 03 '21 13:09 X-Coder264