trezor-firmware icon indicating copy to clipboard operation
trezor-firmware copied to clipboard

Published 20 hours ago • verified publisher icon trezor

feat(core): show success screen after sending a response to the host

Open romanz opened this issue 6 months ago • 7 comments

It should implement similar workflow handling to https://github.com/trezor/trezor-firmware/commit/151eb62150 (keeping the current session until all workflows are over).

romanz avatar May 28 '25 13:05 romanz

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3W1 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

github-actions[bot] avatar May 28 '25 13:05 github-actions[bot]

GetAddress flow:

Screencast from 2025-05-28 20-06-44.webm

romanz avatar May 28 '25 17:05 romanz

Rebasing over #4775 to fix failing tests.

romanz avatar May 31 '25 07:05 romanz

Rebasing to resolve a conflict.

romanz avatar Jun 03 '25 15:06 romanz

THP runs some amount of background loops for retransmissions and some miscellaneous stuff, those must not be interrupted by the session restarts but at the same time aren't workflows

Opened https://github.com/trezor/trezor-firmware/pull/5166, which can be useful for background loops' cancellation.

romanz avatar Jun 10 '25 17:06 romanz

Rebased to resolve a merge conflict.

romanz avatar Jun 18 '25 06:06 romanz

Pushed a small test-related fix (to handle a race in https://data.trezor.io/dev/firmware/ui_report/15725349158/T3W1-en-core_device_test-index.html).

There is no need in the last self.debug.click(self.debug.screen_buttons.ok()) since we use "zero timeout" when animations are disabled.

romanz avatar Jun 18 '25 15:06 romanz

Ran TS5 device tests on 176f0a69a888582937228f4a6dabf0b907eecc5d:

+ pytest tests/device_tests/ -m 'not sd_card' --random-order-seed=1 --random-order-bucket=module
...
=== 1405 passed, 188 skipped, 6 deselected, 12 xfailed in 8898.82s (2:28:18) ===

romanz avatar Jun 20 '25 05:06 romanz

Tested address, xpub and transaction signature confirmation on Suite with BTC Testnet4.

romanz avatar Jun 20 '25 11:06 romanz

@bosomt Please test it all various cases including altcoins, staking, swaps, … with various wallets (not only Trezor Suite)

Hannsek avatar Jun 20 '25 11:06 Hannsek

Related Suite PR.

Hannsek avatar Jun 20 '25 11:06 Hannsek

QA WIP

  • tested in Suite in send, receive, claim reward, swap including receive, ✅
  • Exodus send and receive works as expected ✅
  • https://connect.trezor.io/ fails , needs to be fixed before releasing new 2.9.0 FW into wild ❌

Info:

  • Suite version: desktop 25.7.1 (b381d0268e9406be8b56b209967c2da19afffd81)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/25.7.1 Chrome/134.0.6998.178 Electron/35.1.2 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.9.0 regular (revision a09e6f04d4204607d821d9b742dcf7ffe9c4e2f5)
  • Transport: BridgeTransport 2.0.33

bosomt avatar Jul 03 '25 11:07 bosomt

QA OK Tested on the new 2.9.1 and works on connect.trezor.io 🙏

Info:

  • Suite version: web 25.9.0 (842608cadada6a45f9f7203ac10e786f11e43494)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/139.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1920x1080
  • Device: Trezor T3T1 2.9.1 universal (revision acd56d0113a547e9b5983510b0ce9de079e30e05)
  • Transport: WebUsbTransport

STew790 avatar Sep 01 '25 13:09 STew790