trezor-firmware icon indicating copy to clipboard operation
trezor-firmware copied to clipboard

TT redesign: special screens for altcoins

Open hynek-jina opened this issue 3 years ago • 2 comments

most altcoin functionality is covered by confirm_text / confirm_blob / confirm_properties.

However, there are several custom screens:

  • confirm_total_ethereum -> should be converted to a sequence of "confirm fee" -> "confirm fee" -> "confirm total" or something along these lines
  • confirm_total_ripple -> should be removed in favor of "confirm output" -> "confirm fee" -> "confirm total"
  • confirm_transfer_binance -> should be converted to confirm_properties for inputs, confirm_output for outputs. Unfortunately there doesn't seem to be a sensible way to show total, so some sort of "really confirm? (hold)" with no further info is probably the way to go.
  • confirm_decred_sstx_submission -> figure something out? probably a confirm_properties?

hynek-jina avatar Sep 08 '22 12:09 hynek-jina

Below are the custom screens in their current look.

To make sure, the goal here is to make it look exactly the same, or just "somehow make it work"?

image image image image image

grdddj avatar Sep 13 '22 11:09 grdddj

definitely not "exactly the same".

Instead, figure out how to display the same information in terms of the existing layout types -- or prove that it is not possible in some cases.

Especially in case of Ethereum, I believe the eip1559 variant already does something with confirm_fee / confirm_total, that same logic should also apply to the old signing method.

matejcik avatar Sep 13 '22 11:09 matejcik

Done in https://github.com/trezor/trezor-firmware/pull/2545

grdddj avatar Oct 05 '22 14:10 grdddj