fix(xmr): fix tx sending to an integrated address

[ph4r05]

Fixes sending tx to an integrated address as described in #2213

@matejcik

[ph4r05]

@matejcik I've added a new testing binary https://github.com/ph4r05/monero/releases/tag/v0.18.1.0-dev-tests-u18.04-01

• uses current master
• fixes test using integrated address
• correctly builds transaction with view tags

[ph4r05]

hello @matejcik, hope everything is going fine.

I was wondering, is this PR OK? Or would you prefer me merging it to the #2478?

[ph4r05]

thanks @matejcik ! @onvej-sl when this PR is merged I will start removing old monero code from pre-BP+ era - will save few kBs from the firmware

[ph4r05]

@onvej-sl ping, pls? :)

[ph4r05]

"When your PR is finally accepted and merged" :D Ping, 1 line of code, 1 month, X people cannot send XMR to an integrated address (e.g., exchanges), this PR fixes bug not introduced by me. Pls, any eta? 😅

[ph4r05]

Thanks @mmilata ! 🙏 I will try to remove old XMR code (mainly BP, old and long BP vectors) during the week.

[onvej-sl]

@ph4r05 I apologize for being unresponsive, I must have missed the github notification.

Anyway, as I told @matejcik earlier today, I don't usually have the capacity to review the monero code anymore.

[ph4r05]

sure, no problem @onvej-sl! :)

[grdddj]

when this PR is merged I will start removing old monero code from pre-BP+ era - will save few kBs from the firmware

Will you be looking at old/unused code in micropython or in C? I have scanned the micropython code for unused functions with this result (quite a lot of Monero functions mostly from bulletproof.py), and it is already part of https://github.com/trezor/trezor-firmware/pull/2525