trezor-firmware Model R: Carousel PIN entry

Model R: Carousel PIN entry

Open sime opened this issue 3 years ago • 4 comments

Design: P_20220630_180314

Spec: Given I am on PIN entry And I see 'Enter new PIN' in the center When I press left 4 times Then I should see the number 9 in the center

Given I am on PIN entry And I have entered a PIN And I have 'Show PIN' in the center When I tap 'Confirm' Then I should see the PIN in the top

Given I am on PIN entry And I have entered a PIN And I have 'Delete' in the center When I tap 'Confirm' Then I should delete one digit of my PIN

Given I am on PIN entry And I have 'Exit' in the center When I tap 'Confirm' Then I should be on the homescreen

Jun 30 '22 16:06 sime

Done in 8f00091 as a part of https://github.com/trezor/trezor-firmware/pull/2277

@sime do we want to use this carousel functionality also in other input methods? It could be useful in seed recovery and passphrase

Jul 14 '22 08:07 grdddj

@sime do we want to use this carousel functionality also in other input methods? It could be useful in seed recovery and passphrase

If the effort is trivial, sure. It's handy to have a reference implementation.

The passphrase entry screen concept is currently quite different from the PIN entry UI. More similar on a screen keyboard.

Jul 14 '22 13:07 sime

From the QA POV.

The hold to confirm action when PIN digits confirming by dual pressing needs to be removed.

Jul 14 '22 13:07 sime

The hold to confirm action when PIN digits confirming by dual pressing needs to be removed.

Removed in 0b3589f

Carousel for passphrase added in d36fcc8.

Jul 22 '22 07:07 grdddj