trezor-firmware icon indicating copy to clipboard operation
trezor-firmware copied to clipboard

`confirm_output` does not render subtitle

Open krnak opened this issue 3 years ago • 1 comments

https://github.com/trezor/trezor-firmware/blob/3536d86fa913ff97aa8b8db0332b1cd239b45719/core/src/trezor/ui/layouts/tt/init.py#L513-L514

Problem

Function confirm_output does not render subtitle, because text.content is modified by normal() and then re-set by assignment.

Solution

Replace

text.content = [font_amount, amount, ui.NORMAL, color_to, to_str, ui.FG]

by

text.content.extend([font_amount, amount, ui.NORMAL, color_to, to_str, ui.FG])

Or (preferably) add some new Text methods.

krnak avatar Jan 27 '22 14:01 krnak

Can I fix this? I am new to open source.

iamkaushal avatar Sep 04 '22 16:09 iamkaushal