trezor-firmware icon indicating copy to clipboard operation
trezor-firmware copied to clipboard

Stellar: add support for AMMs related operations.

Open overcat opened this issue 4 years ago • 4 comments

Is your feature request related to a problem? Please describe.

SDF plans to add support for AMMs to Stellar Protocol 18, which will be deployed to the test network today. I personally believe that AMMs related features are important for the users and that these operations will be used with high frequency.

I know you are very busy with Trezor Suit related work right now, I would love to submit a PR to implement these features, would you be able to dedicate resources to review it?

If you have any questions, please let me know, thank you.

Describe the solution you'd like

  • Add support for LiquidityPoolDepositOp and LiquidityPoolWithdrawOp.
  • Extend ChangeTrustOp so that it can add trust lines to liquidity pools.

See: https://github.com/stellar/stellar-protocol/blob/master/core/cap-0038.md#xdr-changes

Describe alternatives you've considered none

Additional context

overcat avatar Oct 06 '21 01:10 overcat

For now, we will not be accepting this addition to Stellar. I'm leaving the issue open for now, for if/when the situation changes.

matejcik avatar Oct 06 '21 08:10 matejcik

For now, we will not be accepting this addition to Stellar. I'm leaving the issue open for now, for if/when the situation changes.

Hi @matejcik, I would like to ask if this status has changed and if you still do not accept the addition of new features.

P.S. Stellar is currently ranked 22 on coinmarketcap.

overcat avatar Sep 22 '23 00:09 overcat

Hello @overcat, the status has indeed changed. Feel free to go ahead with the PR and feel free to open issues for other missing Stellar features.

matejcik avatar Nov 28 '23 12:11 matejcik

Hi @matejcik, thank you for your reply, I have already placed it on my schedule.

overcat avatar Nov 29 '23 15:11 overcat