node-named icon indicating copy to clipboard operation
node-named copied to clipboard

new version to npm

Open demmer opened this issue 10 years ago • 5 comments

Can you please publish a new version to npm since I'd like to be able to run with the fix from 73719b0070721ac50115f8895ca799dc6acedd74.

Thanks!

demmer avatar Mar 11 '15 23:03 demmer

Same here but I'm not fond of this fix.

Surely it should just need a return statement in the catch.

    if (!dobj.val)
            return null;

This could be changed to throw. Part of the problem here is inconsistency (protocol throws TypeError but query returns null).

Any kind of unhandled error though should just be a fatal one. Hiding application errors is how hacks happen or how bugs just get hidden away.

I would suggest something like an instanceof check. For example, if(e instanceof ExpectedError)emit else throw(e)...

Though I don't really know the best way in JS to really achieve that.

Anyway, even if the fix is imperfect we still need this in npm. It's a critical problem. My daemon is constantly going down because of this. You can knock it out by just sending anything random to the UDP port.

joeyhub avatar Apr 16 '15 09:04 joeyhub

bump.

derhuerst avatar Aug 18 '16 17:08 derhuerst

bump :P

h43z avatar Nov 12 '18 01:11 h43z

Bump

Saiv46 avatar Mar 06 '19 13:03 Saiv46

bump

ghost avatar Apr 24 '20 22:04 ghost