Inconsistent Grammar

[asmodeus812]

Problem description

Hi. I have noticed some inconsistencies between the java grammar in treemacs' port for emacs and nvim for example here are two screens of the same code that are missing some things

As you can see annotations are coloured as are keywords, variable usage is not coloured at all, member function calls as well. Vscode and nvim are consistent and look the same while in emacs it seems that only partial highlight is done.

[raghav-deepsource]

maybe the extensions are using different versions of tree-sitter-java?

[asmodeus812]

I dont think so, the emacs ts highlighting is no better than a plain regex from what i see.

[catarinacps]

I believe the difference you see stems from the fact that both emacs-tree-sitter (using tree-sitter-langs) and NeoVim maintain their own highlights.scm file. https://github.com/emacs-tree-sitter/tree-sitter-langs/blob/master/queries/java/highlights.scm you can see that the highlights.scm file used by emacs-tree-sitter hasn't been updated in over two years and even differs from the queries/highlights.scm from this repository. I also believe that the NeoVim tree-sitter maintainers further enhance their highlights.scm files, which could also contribute to the difference you observe.

Unfortunately, there is no escape in that, as the highlight tags used in this repo, in the Emacs highlighter and the NeoVim highlighter naturally differ (the names may differ, NeoVim could have more highlighting tags, etc). That way, it's hard to contribute to the original grammar repository any enhancements to the highlighting queries that any one of these editors make.

Of course, there are similarities between the highlighting tags, but the process is manual and the maintainers do this for free on their spare time. If you feel inclined, I'd suggest you take a look at the highlighting queries made by NeoVim and then replicate those to the Emacs implementation, following the stylistic patterns from the other highlighting queries in the implementation.