django-bootstrap-modal-forms icon indicating copy to clipboard operation
django-bootstrap-modal-forms copied to clipboard

Published 20 hours ago • verified publisher icon trco

Allow models.PROTECT in the models

Open monsanto-pinheiro opened this issue 5 years ago • 3 comments

Catch exception 'ProtectedError' when try to remove a pk with a relation in the model. Only have to define "on_delete=models.PROTECT" in the model fields.

monsanto-pinheiro avatar Apr 10 '20 17:04 monsanto-pinheiro

@monsanto-pinheiro Thanks for your PR, however I can't consider it unless it includes test for the change. Please add a test and I would gladly approve this PR.

trco avatar Apr 10 '20 18:04 trco

I only did tests for 'tests_unit'. I didn't for functional. Please, can you do it? cheers,

monsanto-pinheiro avatar Apr 10 '20 22:04 monsanto-pinheiro

@monsanto-pinheiro Same as in https://github.com/trco/django-bootstrap-modal-forms/pull/126#issuecomment-1615846203. Sorry for not including your PR back in 2020. I'm again working on this package from time to time thus I would like to ask you if you're interested in adjusting this outdated PR to the current code. It would be great to have you as collaborator. Otherwise I would like to thank you for your contribution and include your idea in one of the next releases.

trco avatar Jul 01 '23 10:07 trco