hass-pfsense icon indicating copy to clipboard operation
hass-pfsense copied to clipboard

Published 20 hours ago • verified publisher icon travisghansen

Do not use deprecated units

Open MattyRoy opened this issue 1 year ago • 3 comments

Many of the units from Home Assistant are deprecated and will be removed in 2025.1 - this pull request moves away from the deprecated units.

MattyRoy avatar Jan 09 '24 09:01 MattyRoy

Ha! I just discovered this PR. I didn't see it when I created mine as #183 The only thing I would suggest on this PR is to run isort to ensure the imports are ordered correctly.

epenet avatar Jan 09 '24 13:01 epenet

Thanks, I have pushed the changes after run isort!

MattyRoy avatar Jan 09 '24 19:01 MattyRoy

@travisghansen it would be good to be rid of these warnings. The new constants have been available for a few years already...

epenet avatar Jan 30 '24 12:01 epenet

Thanks for the contribution! I didn't see this until I already updated them. Try the latest version and if I missed something let's open a new PR.

travisghansen avatar Feb 16 '24 18:02 travisghansen