external-auth-server icon indicating copy to clipboard operation
external-auth-server copied to clipboard

Logging and misc improvements

Open sseppola opened this issue 4 years ago • 1 comments
trafficstars

Hi, we've been playing around with this for a couple of days now and made some improvements you may want. They're mainly concerning logging to allow us to figure out what was happening on our end.

We found that if scope was only "openid offline_access" then of course no access_token is issued. While not a big problem access_token = null caused access_token_assertions to throw an error. I added a check and a log entry in order to handle it gracefully, then did the same for id_token in case someone don't have openid in the scope.

Lastly, like we discussed in #131 we got a domain mydomain.comundefined because x-forwarded-uri was assumed to have a value. So we added a fallback value as it's better to have no path than mess up the domain.

sseppola avatar Nov 03 '21 14:11 sseppola

Thanks for the contribution! I'll look a little more closely when I have a moment and provide some feedback.

travisghansen avatar Nov 03 '21 14:11 travisghansen