argo-cd-helmfile icon indicating copy to clipboard operation
argo-cd-helmfile copied to clipboard

Published 20 hours ago • verified publisher icon travisghansen

[OCI Helm repo compatability]: Add support for optional skip of passing versions of k8s and APIs from command line

Open GolubevV opened this issue 1 year ago • 1 comments
trafficstars

In the current implementation, Helmfile is passing all supplied arguments and env varialbes down to Helm tool.

However, in the case of working with OCI repositories for Helm charts, helmfile performs explicit pull from OCI before render and does not support the extra args that are inherited like --kube-version or --api-verssions.

As a result, it fails with the error like Error: unknown flag: --kube-version

This PR allows to skip passing the K8s and API versions if corresponding ENV variable HELMFILE_PASS_VERSIONS is set to false. By default, if not explicitly specified, it will be set to true to be backward compatible with previous behaviour.

@travisghansen - please tell. if you think we should consider to include this parameter into discovery output thus making it globally visible.

GolubevV avatar Feb 05 '24 13:02 GolubevV

@travisghansen any feedback on this PR ??

kikokikok avatar Oct 27 '24 22:10 kikokikok

Can you send an example of how/when the oci bits break? I use oci registries and haven’t ran into this issue for some reason.

travisghansen avatar Jun 15 '25 15:06 travisghansen

I guess this is no longer relevant in context of https://github.com/travisghansen/argo-cd-helmfile/issues/71

crabique avatar Jul 15 '25 10:07 crabique

Yes I believe you are correct.

travisghansen avatar Jul 15 '25 13:07 travisghansen