Results 370 comments of Travis Downs

Hunting down some nonsensical instruction counts in a perf test and this turned out to be the cause. Note that this only affects tests that use `perf_tests::start_measuring_time()` as tests which...

I think @bhalevy has also been in this area recently and may have added the `perf_stats` functionality (very nice, BTW).

> Can you please run the existing tests and quote before and after numbers > to if and what changed, to make sure they still make sense. You mean in...

I had trouble running fair_queue_perf, as described in https://github.com/scylladb/seastar/issues/1175, fix is in the associated PR.

@bhalevy I have now run all the existing `_perf` tests before and after this change (both runs included the cherry-picked fix for #1175), like so: ``` for t in $PTESTS;...

Thanks Benny for the review, it's appreciated.

FWIW this would be very useful. Java 8 offers limited support for unsigned types, and in particular it does not offer UnsignedShorts.checkedCast() (it only offers widening conversions). That happens to...

@thespags - the wayback machine [has it](https://web.archive.org/web/20160111161220/http://code.google.com/p/guava-libraries/issues/attachmentText?id=1268&aid=12680001000&name=ArrayListVsImmutableList.java&token=ABZ6GAdWly6Cfrl6SG6cZbDxXSS0PEMH_A%3A1452527855184). I've attached it here (because I can't attach it to the first message in this thread): [ArrayListVsImmutableList.zip](https://github.com/google/guava/files/7709369/ArrayListVsImmutableList.zip)

I got a failure in this test but different to Ben's: this was complaining about BadLogLines: https://buildkite.com/redpanda/redpanda/builds/13828#01827fde-bcb1-487b-b14f-9ad6dded442f ``` -------------------------------------------------------------------------------- -- [INFO:2022-08-09 00:51:17,651]: RunnerClient: rptest.tests.partition_balancer_test.PartitionBalancerTest.test_full_nodes: FAIL: Traceback (most recent call last):...

I made it through it! Looks like a few nice scale test is shaping up. I had a few miscellaneous questions and suggestions, nothing major.