coveralls-maven-plugin icon indicating copy to clipboard operation
coveralls-maven-plugin copied to clipboard

Added support for Open Clover

Open dogeared opened this issue 8 years ago • 6 comments

Now that Atlassian has totally open-sourced clover, I wanted to add its support to this plugin.

I saw that you had a clover branch, but it's 3 years old and only seemed to be scaffolding anyway.

dogeared avatar Sep 04 '17 01:09 dogeared

After integrating this PR into my fork, I saw that there are test failures. any idea why? Do you still actively use this integration?

jwgmeligmeyling avatar Apr 01 '19 15:04 jwgmeligmeyling

@JWGmeligMeyling yes, we still actively use it, but we had to create a fork with the fix until this PR could be merged. @dogeared any idea?

lhazlewood avatar Sep 27 '19 22:09 lhazlewood

@trautonen what is necessary to get this merged?

lhazlewood avatar Apr 23 '22 23:04 lhazlewood

Hello @trautonen - I was looking to freshen this up. I thought I'd make a new branch off master and cherry pick my changes in.

However, I am unable to build the project locally, currently. Here's what I'm getting:

git submodule update
Cloning into '/Users/micahsilverman/Projects/coveralls-maven-plugin.new/etc'...
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: clone of 'git://github.com/trautonen/etc.git' into submodule path '/Users/micahsilverman/Projects/coveralls-maven-plugin.new/etc' failed
Failed to clone 'etc'. Retry scheduled
Cloning into '/Users/micahsilverman/Projects/coveralls-maven-plugin.new/etc'...
fatal: remote error:
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
fatal: clone of 'git://github.com/trautonen/etc.git' into submodule path '/Users/micahsilverman/Projects/coveralls-maven-plugin.new/etc' failed
Failed to clone 'etc' a second time, aborting

And, without the etc submodule, mvn clean install fails.

Any guidance would be appreciated!

dogeared avatar Apr 26 '22 12:04 dogeared

Unfortunately, I also had no proper way to simulate the real environment used to build and publish this project yet. I'm looking forward that to try to bring this project from the grave.

PabloThiele avatar Jun 21 '23 11:06 PabloThiele

Yea, it could be that the checkstyle config is required from the etc project. But it would make sense to remove this submodule dependency completely and also change the build to github actions. I won't promise, but I'll try to spend some time end of this week to make this running again.

trautonen avatar Jun 21 '23 12:06 trautonen