Remove Makefile

[eerison]

I'ts a suggestion to remove Makefile

[codecov[bot]]

Codecov Report

Merging #47 (c3f379e) into master (d1fb224) will decrease coverage by 13.47%. The diff coverage is n/a.

@@              Coverage Diff              @@
##             master      #47       +/-   ##
=============================================
- Coverage     93.26%   79.79%   -13.48%     
  Complexity       68       68               
=============================================
  Files             5        5               
  Lines           193      193               
=============================================
- Hits            180      154       -26     
- Misses           13       39       +26     

Impacted Files	Coverage Δ
lib/transloadit/TransloaditRequest.php	58.00% <0.00%> (-40.00%)	:arrow_down:
lib/transloadit/Transloadit.php	79.68% <0.00%> (-7.82%)	:arrow_down:
lib/transloadit/CurlRequest.php	89.58% <0.00%> (-2.09%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d1fb224...c3f379e. Read the comment docs.

[eerison]

Hey @goto-bus-stop

it's what I mentioned to move the commands from Makefile to composer.json

what do you think?

[eerison]

@goto-bus-stop the tests are skipped because I don't have access to the keys from my Pull request!

it's skipping here: https://github.com/transloadit/php-sdk/blob/master/test/bootstrap.php#L13

what do you think the coverage test run for unit tests only? otherwise when someone open a PR the pipeline will fail :'(

[eerison]

Hey @goto-bus-stop any answer for this PR? do you have any question about the changes?

[eerison]

👀

[goto-bus-stop]

Sorry 🙈

I think we should keep the Makefile. I think it's a good idea to move things into composer scripts and phpunit xml config, but all transloadit projects have a Makefile, so our devs can use the same commands in every repository. The generate-example-docs should also stay, the fact that we didn't run it with some previous releases is a mistake, it should be used so the examples and readme both stay updated.