node-sdk icon indicating copy to clipboard operation
node-sdk copied to clipboard

Published 20 hours ago • verified publisher icon transloadit

upgrade to yarn 4

Open mifi opened this issue 1 year ago • 1 comments

Note: breaking change (requires node>=18)

TODO

  • [ ] replace np with something that works with yarn 4 (and update readme) #169

mifi avatar Nov 07 '23 15:11 mifi

I've tried to tinker with upgrading np to support yarn berry and it seems to be working, but I haven't done tests yet: https://github.com/mifi/np/pull/1

mifi avatar Nov 08 '23 14:11 mifi

upstream np accepts yarn 4 now as indicated in https://github.com/mifi/np/pull/1, so we could likely upgrade np along with yarn and settle here

kvz avatar Aug 02 '24 14:08 kvz

yes but I think it would be a breaking change?

mifi avatar Aug 04 '24 20:08 mifi

Only for contributors, not for consuming devs that added it as a dependency correct? Can’t they just npm/pnpm/yarn1 install this when it’s part of a project?

kvz avatar Aug 05 '24 06:08 kvz

I’m running into the same problem in #176. Vitest also requires Node.js >=18. Although I personally prefer to test against all supported Node.js versions, I suggest we drop tests for Node.js 14 and 16 so we can upgrade Yarn and Vitest. The upcoming TypeScript migration will define a target matching Node.js 14, so the odds of breaking Node.js 14 support are slim.

remcohaszing avatar Aug 13 '24 13:08 remcohaszing

yea im fine with not testing against old versions for now

mifi avatar Aug 13 '24 15:08 mifi