node-sdk icon indicating copy to clipboard operation
node-sdk copied to clipboard

re-enable scheduled tests

Open mifi opened this issue 3 years ago • 1 comments

until we can implement a localtunnel replacement, I disabled the scheduled tests in https://github.com/transloadit/node-sdk/commit/90cdfc6d69584cedbafd88058159c177fea5f34f in order to reduce noise. need to re-enable

https://github.com/transloadit/node-sdk/issues/89#issuecomment-1194003057

mifi avatar Jul 28 '22 10:07 mifi

now that the cloudflare tunnel is implemented, we could close this, but fixing the tunnel reveals that the eventual consistency in api2 is still an issue, causing the same test to fail sporadically, so we need to fix that first:


  ● API integration › assembly cancelation › should stop the assembly from reaching completion

    expect(received).toBe(expected) // Object.is equality

    Expected: "ASSEMBLY_CANCELED"
    Received: "ASSEMBLY_EXECUTING"

      445 |         const resp2 = await client.getAssembly(id)
      446 |         console.log(`Expect Assembly ${id} to return 'ASSEMBLY_CANCELED'`)
    > 447 |         expect(resp2.ok).toBe('ASSEMBLY_CANCELED')
          |                          ^
      448 | 
      449 |         // Check that awaitAssemblyCompletion gave the correct response too
      450 |         const awaitCompletionResponse = await awaitCompletionPromise

      at Object.it (test/integration/__tests__/live-api.js:447:26)

https://github.com/transloadit/node-sdk/runs/7617455306?check_suite_focus=true

mifi avatar Aug 01 '22 18:08 mifi