pe-parse icon indicating copy to clipboard operation
pe-parse copied to clipboard

Reduce reference set of pe-parse - peparse::`dynamic initializer for 'ProductIdMap''

Open Alan-Jowett opened this issue 2 years ago • 1 comments
trafficstars

This library has a dynamic initializer for ProductIdMap and ProductMap, which causes the process to allocate and commit 13 pages.

Ask: Allocate these pages on demand.

Both of these objects are only used in parse.cpp and are used from GetRichProductName and GetRichObjectType.

Proposal: Switch these to allocate these data structures on demand.

Alan-Jowett avatar Jul 17 '23 21:07 Alan-Jowett

Thanks for reporting @Alan-Jowett!

I can't promise any immediate availability to improve this, since the current version of the library is mostly in maintenance mode. That being said, I'd be happy to review a PR that changes the initialization behavior to on-demand.

woodruffw avatar Jul 19 '23 20:07 woodruffw