traefik-helm-chart icon indicating copy to clipboard operation
traefik-helm-chart copied to clipboard

Published 20 hours ago • verified publisher icon traefik

Pod disruption budget should allow percentages

Open hintofbasil opened this issue 5 years ago • 2 comments

A pod disruption budget should allow percentages for the .spec.minAvailable and .spec.maxUnavailable fields. https://kubernetes.io/docs/tasks/run-application/configure-pdb/#specifying-a-poddisruptionbudget

The chart casts them to integers which disallows this. https://github.com/containous/traefik-helm-chart/blob/289d2b2/traefik/templates/poddisruptionbudget.yaml#L17

hintofbasil avatar Sep 08 '20 21:09 hintofbasil

Is there a particular reason to prevent percentages by converting to integer as mentionned above please ?

If there is none, I can make a PR to allow percentages if you want

yogeek avatar Oct 21 '21 16:10 yogeek

We used to face a downtime of our production because of this conversion which lead to change 50% to 0. Thanks for opening this issue guys, I created a corresponding PR to fix it.

LudovicTOURMAN avatar Nov 25 '21 17:11 LudovicTOURMAN

Fixed with #528

mloiseleur avatar Oct 28 '22 09:10 mloiseleur