🐛 Bug Report: Pinecone - No Span Attributes defined for upsert and delete of pinecone.Index class

[elinacse]

Which component is this bug for?

Pinecone Instrumentation

📜 Description

Currently we don't get span attributes for upsert and delete methods . Only query() has span attributed defined .

👟 Reproduction steps

implement pinecone.Index class query , upsert and delete methods . We will get span attributes only for query().

👍 Expected behavior

We should get span attributes for upsert and delete methods as well like chromadb and Milvus Db.

👎 Actual Behavior with Screenshots

🤖 Python Version

3.11

📃 Provide any additional context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

• [x] I checked and didn't find similar issue

Are you willing to submit PR?

Yes I am willing to submit a PR!

[dosubot[bot]]

The current implementation of span attributes for the upsert and delete methods in Pinecone Instrumentation is not defined, which is why you're only seeing span attributes for the query method. To address this, you can look at how span attributes are defined for similar operations in other databases like ChromaDB. For example, ChromaDB sets specific attributes on the span related to the operation being performed, such as counts of embeddings, metadatas, and documents for upsert, and ids and where conditions for delete ^[1].

You can adapt these implementations to define span attributes for the upsert and delete methods in Pinecone Instrumentation. This would involve setting relevant attributes on the span for these operations, similar to how it's done for the query method in Pinecone ^[2].

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other}

[nirga]

Thanks @elinacse! Do you plan on working on this?

[TheMellyBee]

I also would like this.