openllmetry icon indicating copy to clipboard operation
openllmetry copied to clipboard

🚀 Feature: extract semantic conventions

Open nirga opened this issue 2 years ago • 5 comments
trafficstars

Which component is this feature for?

All Packages

🔖 Feature description

As the instrumentations grew, there are some semantic conventions that should be extracted out of the individual packages into the common one, namely:

  • LLM prompts
  • Prompt keys
  • Whether to disable prompt logging for privacy reasons

🎤 Why is this feature needed ?

Order in the repo :)

✌️ How do you aim to achieve this?

.

🔄️ Additional Information

No response

👀 Have you spent some time to check if this feature request has been raised before?

  • [X] I checked and didn't find similar issue

Are you willing to submit PR?

None

nirga avatar Oct 26 '23 16:10 nirga

@nirga he is this open still?

SANJITH-KUMAR-20 avatar Apr 10 '24 11:04 SANJITH-KUMAR-20

Yes @SANJITH-KUMAR-20. We need to extract strings that are used for attribute names to the common package.

nirga avatar Apr 10 '24 13:04 nirga

Maybe I can try working on this if you ellaborate a bit... Becasue I am new here and I haven't used openllmetry

SANJITH-KUMAR-20 avatar Apr 11 '24 12:04 SANJITH-KUMAR-20

@SANJITH-KUMAR-20 sure! If you look across the code you'll see many places where we set an attribute by specifying its name instead of using a constant. We should purge them and move them all to constants here.

nirga avatar Apr 11 '24 17:04 nirga

Oh ok I get it... I will look into it and will start working on this in a few days time!

SANJITH-KUMAR-20 avatar Apr 13 '24 12:04 SANJITH-KUMAR-20

Hi @nirga, is this issue still open? if not I would like to work on it!

ArunimSamudra avatar May 21 '24 21:05 ArunimSamudra

Yes please!

nirga avatar May 21 '24 21:05 nirga

Thanks

ArunimSamudra avatar May 21 '24 21:05 ArunimSamudra