burn
burn copied to clipboard
Feature request: `Tensor::arctan` and other inverse trigonometric functions
Feature description
It would be great to have support for the inverse trigonometric functions on Tensors (f32, f64 if possible). This includes:
arctanarccosarcsinarccotarcsecarccsc
Feature motivation
I'm giving Burn and alternatives a spin with some simple scientific computing routines. arctan is required for a specific calculation.
Hi! I'd like to try implementing the inverse trig functions. I haven't contributed to this project yet.
My plan is to:
- Start with arctan
- Implement across all backends (ndarray, candle, etc.) 3.. Add comprehensive tests
- Would you also like me to implement in the same PR the automatic differentiation and IR?
Should I implement all 6 functions in one PR, or would you prefer them split up? Are there any specific considerations for the mathematical implementations?
Thank you for your initiative! Smaller independent PRs are preferable especially since they're independent. Also you might learn on the pay. If you're not familiar with the project structure, you can read up on the contributor's book: https://burn.dev/books/contributor/
Commenting again for visibilities sake: Makes sense, I will give it a try however for fun and will do a PR if I get anywhere!