burn
burn copied to clipboard
Add cumsum
Pull Request Template
I'm opening the PR draft early just to see if i'm on the right track!
Checklist
- [ ] Confirmed that
run-checks allscript has been executed. - [x] Made sure the book is up to date with changes in this PR.
- [x] ndarray
- [x] candle
- [x] tch
- [x] autodiff
- [ ] jit
- [x] fusion
- [ ] import
Related Issues/PRs
Issue: https://github.com/tracel-ai/burn/issues/1720
Changes
Add cumsum for ndarray
Testing
Added unit test
Just be aware there is an open PR related https://github.com/tracel-ai/burn/pull/1722
Maybe we could combine the efforts? Although the author just came back with a response.
I would recommend taking on import change in a separate PR.
Just be aware there is an open PR related #1722
Maybe we could combine the efforts? Although the author just came back with a response.
Oh i didn't see there was an existing one already!
Would it be worth merging a version without the burn-jit backend first?
And then add the burn-jit and burn-import separately?
Just be aware there is an open PR related #1722 Maybe we could combine the efforts? Although the author just came back with a response.
Oh i didn't see there was an existing one already! Would it be worth merging a version without the
burn-jitbackend first? And then add theburn-jitandburn-importseparately?
Sorry for the delayed response here, didn't notice this draft 🫣
I think we can definitely start without the burn-jit and burn-import implementation, we can isolate that in another PR if it's currently blocking.
The ONNX import has been partially completed in the linked PR, so it could be completed from there.
This PR has been marked as stale because it has not been updated for over a month
Closing in favor of #2664 (WIP), which is up to date with main.
Will make sure to add proper attribution in the commit co-authors.