burn icon indicating copy to clipboard operation
burn copied to clipboard

Huber loss tests fail

Open rubenjr0 opened this issue 1 year ago • 1 comments

Describe the bug Some Huber loss related tests fail:

  • nn::loss::huber::tests::test_huber_ad_loss
  • tests::jit::kernel::reduction::reduction::reduction_sum_should_work_with_multiple_invocations
  • nn::loss::huber::tests::test_huber_loss

The test_huber_ad_loss fails when running cargo test:

thread 'nn::loss::huber::tests::test_huber_ad_loss' panicked at crates/burn-autodiff/src/gr
 aph/backward.rs:46:5:
 assertion failed: checkpointer.is_empty()

And the test_huber_loss fails when running ./run-checks.sh std:

thread 'nn::loss::huber::tests::test_huber_loss' panicked at crates/burn-core/src/nn/loss/huber.rs:153:14:
Tensors are not approx eq:
  => Position 0: 1.4200000762939453 != 1.4199999570846558 | difference 0.00000011920928955078125 > tolerance 0.00000010000000000000004

Both tests fail on a fresh main branch.

To Reproduce

  1. Clone the main branch
  2. Run cargo test
  3. Run ./run-checks.sh std

Hardware

  • OS: Pop!_OS 22.04
  • GPU: NVIDIA GeForce GTX 1060 6GB
  • CPU: AMD Ryzen 5 2600X

rubenjr0 avatar Mar 15 '24 15:03 rubenjr0

Since you guys are working on this: @nathanielsimard

antimora avatar Mar 15 '24 20:03 antimora