burn icon indicating copy to clipboard operation
burn copied to clipboard

Fix: Records no longer require Debug and Clone

Open nathanielsimard opened this issue 1 year ago • 2 comments

Clone and Debug are never used on Record::Item but were generated within the derive macro. It made it impossible to create a Record generic over another Record.

nathanielsimard avatar Jan 12 '24 16:01 nathanielsimard

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9bd2d7b) 85.69% compared to head (b161f39) 85.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1137   +/-   ##
=======================================
  Coverage   85.69%   85.70%           
=======================================
  Files         513      513           
  Lines       56987    56987           
=======================================
+ Hits        48837    48838    +1     
+ Misses       8150     8149    -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 12 '24 16:01 codecov[bot]

Can you please give more context here? Just want to make sure my current deserialization won't break.

antimora avatar Jan 12 '24 17:01 antimora

This broke my tests:

image

image

Clone is needed if item is behind vector.

antimora avatar Jan 18 '24 23:01 antimora