ItemSwapper icon indicating copy to clipboard operation
ItemSwapper copied to clipboard

Request: This mod for Forge 1.16.5

Open Maya1924 opened this issue 2 years ago • 6 comments

Is your feature request related to a problem?

No

Describe the solution you'd like

I'm playing Enigmatica 6 Expert. I love this mod, but E6E is forge and 1.16.5. Just thought I'd put in a request for it!

Describe alternatives you've considered

No response

Additional context

No response

Maya1924 avatar Jul 28 '23 21:07 Maya1924

Probably no. A forge version some time later, but then 1.20 and 1.19.4.

tr7zw avatar Jul 28 '23 21:07 tr7zw

Probably no. A forge version some time later, but then 1.20 and 1.19.4.

instead of making another issue thread ill just ask here, could u port it to 1.16.5 fabric maybe?

gabrielzv1233 avatar Aug 28 '23 21:08 gabrielzv1233

Probably no. A forge version some time later, but then 1.20 and 1.19.4.

instead of making another issue thread ill just ask here, could u port it to 1.16.5 fabric maybe?

Same issue as Forge 1.16. It would require a major amount of work for which I don't have the time right now(or much interest in, as I don't play old versions). If someone feels adventurous, feel free to try to create a PR, but to port it back to 1.16 you have to get through a lot of stuff like Java 17 -> Java 8(so removing all instance of switches/records) and the old screen system. The only good starting point would be the 1.18 backported version.

tr7zw avatar Aug 28 '23 21:08 tr7zw

Out of curiosity, tried compiling the 1.18 source against 1.16, and it mainly failed at the Java 17->8 issues (20 errors). So potentially it's actually not too bad?

tr7zw avatar Aug 28 '23 21:08 tr7zw

Ok yea, main issues: RenderSystem Shader/setShaderTexture are gone The logic around accessing the shulker content is gone/renamed? The network packets identifier and data are private without a getter, so you can't access them without breaking it open?!? So neither the rendering nor shulkers will work without having to do a deep dive into which magic numbers/methods need to be used in 1.16.

tr7zw avatar Aug 28 '23 22:08 tr7zw

So is that a maybe?

On Mon, Aug 28, 2023 at 5:13 PM tr7zw @.***> wrote:

Ok yea, main issues: RenderSystem Shader/setShaderTexture are gone The logic around accessing the shulker content is gone/renamed? The network packets identifier and data are private without a getter, so you can't access them without breaking it open?!? So neither the rendering nor shulkers will work without having to do a deep dive into which magic numbers/methods need to be used in 1.16.

— Reply to this email directly, view it on GitHub https://github.com/tr7zw/ItemSwapper/issues/169#issuecomment-1696498224, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASNYESFAPD4XXB65V4WQQA3XXUJZTANCNFSM6AAAAAA24ABM4Y . You are receiving this because you commented.Message ID: @.***>

-- NOTICE: This communication and any response to it may constitute a public record, and therefore, may be available upon request under Iowa public records law, Iowa Code Chapter 22.

gabrielzv1233 avatar Aug 28 '23 22:08 gabrielzv1233