FirstPersonModel icon indicating copy to clipboard operation
FirstPersonModel copied to clipboard

Sitting on modded chairs breaks players offset unless facing south

Open egshels opened this issue 4 years ago • 1 comments

image image image This happens for every modded seat. I'm not sure if this is fixable without just redoing how offset works when sitting

egshels avatar Jan 19 '21 05:01 egshels

Easily fixable by removing the last else statement from the public void updatePositionOffset(Entity player, Vec3 defValue) function in MinecraftWrapper at the check for vehicles.

Removing this makes the earlier defined realYaw value used instead of the riden vehicle, which for most modded seats doesn't change direction.

I have fixed this locally, just lacking permissions to create a pull request.

mashedram avatar Dec 24 '23 23:12 mashedram

This has been resolved, together with other sitting rotation issues.

tr7zw avatar Jun 08 '24 22:06 tr7zw