EntityCulling icon indicating copy to clipboard operation
EntityCulling copied to clipboard

[BUG] Fabric version depend on Fabric API but doesn't declare it in FMJ

Open Julienraptor01 opened this issue 1 year ago • 4 comments

I was testing things for another bug and narrowed it down to potentially be caused by EntityCulling so i tried to remove all mods but it since it doesn't have any dependencies and launch the game however this did produce a crashlog by reading lines 25 and 31, you can easily see that the mod tries to call some code from the fabric API, but doesn't succeed

25: Caused by: java.lang.NoClassDefFoundError: net/fabricmc/fabric/api/client/event/lifecycle/v1/ClientTickEvents
31: Caused by: java.lang.ClassNotFoundException: net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientTickEvents

this is due to the code right here https://github.com/tr7zw/EntityCulling/blob/987fdb1dac616d180e4a2c93b1e89b15e003bf3a/EntityCulling-Fabric/src/main/java/dev/tr7zw/entityculling/EntityCullingMod.java#L19-L24

Julienraptor01 avatar Jan 09 '24 21:01 Julienraptor01

Hm true, will fix that next release. I keep forgetting that, as the CurseForge launcher installs the Fabric API by default anyway.

tr7zw avatar Jan 09 '24 21:01 tr7zw

Hm true, will fix that next release. I keep forgetting that, as the CurseForge launcher installs the Fabric API by default anyway.

OOF truly a CursedForge moment

Julienraptor01 avatar Jan 09 '24 21:01 Julienraptor01

Without them, none of my mods would be a thing... sooo^^ But yea, starting fabric without the API is usually never correct.

tr7zw avatar Jan 09 '24 21:01 tr7zw

God, this issue caused so many issues.

tr7zw avatar Jan 16 '24 15:01 tr7zw