python-configuration icon indicating copy to clipboard operation
python-configuration copied to clipboard

Published 20 hours ago • verified publisher icon tr11

add compatibility with pathlib.Path type from stdlib.

Open publicmatt opened this issue 1 year ago • 1 comments

I believe this fixes the issue I opened: #96

It adds type hinting pathlib.Path to each of data parameter, and adds a Path to the isinstance check before calling open() on the path.

publicmatt avatar Apr 05 '24 20:04 publicmatt

Can you also add tests to ensure coverage? Here are the instructions on how to do that. Otherwise, I can take a look at it next weekend.

tr11 avatar Apr 08 '24 15:04 tr11

Can you also add tests to ensure coverage? Here are the instructions on how to do that. Otherwise, I can take a look at it next weekend.

I've installed hatch and was able to run the tests. Can you explain some of the errors I'm seeing? Do I have to run ruff or mypy on the source to sort import and fix line lengths?

publicmatt avatar Apr 17 '24 15:04 publicmatt