Thomas Praxl

FYI: This seem to be the critical relations: 

I am struggling, because madge shows that in this branch, I actually increased the amount of circular dependencies when I untangled index.js / promise.js (because there are more files now)....

My proposal after having thought about it again: Let's merge https://github.com/tpraxl/node-mysql2/tree/fix/circular-dependencies-promise into this PR. Have it reviewed thoroughly before the merge. (Next week, I am planning to test this version...

Merged fix/circular-dependencies-promise into this branch. **Summary:** This PR fixes the crash for esm apps using the callback variant of mysql2 with open telemetry mysql2 instrumentation. Open telemetry mysql2 instrumentation is...

@mknj thanks for your findings. You are even better than `npm run lint` . That should have been my job. Sorry.

Good news: Actually reading the complete documentation of opentelemetry helps. :eyes: I found out that, in order to have proper support for instrumentation in esm, you need to use the...

> @tpraxl, can I make some minor adjustments directly to your branch? Of course, feel free.

Just to clarify: This is standard behavior in PHPUnit as well. At this point, pest simply uses PHPUnit here, as far as I can tell: [src/PendingCalls/TestCall.php](https://github.com/pestphp/pest/blob/3.x/src/PendingCalls/TestCall.php#L132) -> https://github.com/sebastianbergmann/phpunit/blob/main/src/Framework/TestCase.php#L1059 -> https://github.com/sebastianbergmann/phpunit/blob/main/src/Framework/TestCase.php#L2200

> Is someone else able to reproduce this? I just added the example test and the global hooks to a fresh laravel project and ran `vendor/bin/pest tests/Unit/ExampleTest.php`. My output is...

Maybe this test is a good headstart? https://github.com/pestphp/pest/blob/3.x/tests/Hooks/AfterEachTest.php How would you change it to reflect the documented (and most likely the intuitive) order?