openplatform icon indicating copy to clipboard operation
openplatform copied to clipboard

Seriously, great work, but some minor implementation issues...

Open rwdim opened this issue 6 years ago • 3 comments

"value && value.items.length" is bad and is throwing errors.. in users-grid.html

Everywhere this kind of check is used should be replaced with

values && Array.isArray( value.items ) ....

Current code assumes values is never null, and also that items is always a non-null array.

Also, in admin.html, this code fails when value is null.. there's no check...

	Thelpers.groups = function(value) {

		if (!value.length)
			return '';
Screen Shot 2019-10-25 at 12 02 52 PM

rwdim avatar Oct 25 '19 17:10 rwdim

Hmmm, value can't be null. Can you check server-side logs in terminal? Or can you send me the response from the server?

petersirka avatar Oct 25 '19 17:10 petersirka

Will do.

rwdim avatar Oct 25 '19 17:10 rwdim

Ok... it looks like you're developing in your master branch?, so I checked out v4.1.0 and it works as expected.

Not as pretty, but it seems to work. Clean checkout of master throws numerous errors when viewing the user list... /api/op/users/ generates an error response in json stating that column 'note' does not exist.

I'll play with v4.1 for now... thx :)

rwdim avatar Oct 25 '19 20:10 rwdim

On our end, it was an eternity instead of a delay. We prepared a brand-new version that includes all of the fixes. Really sorry.

petersirka avatar Jan 15 '23 14:01 petersirka