es-toolkit icon indicating copy to clipboard operation
es-toolkit copied to clipboard

fix(countBy): Support nemeric and symbol keys in `countBy`

Open mass2527 opened this issue 1 year ago • 2 comments

For consistency, the countBy function should support readonly arrays and non-string keys, like groupBy, so I made the change.

mass2527 avatar Aug 26 '24 13:08 mass2527

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 1:34pm

vercel[bot] avatar Aug 26 '24 13:08 vercel[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.77%. Comparing base (d02ef35) to head (e8c3d1d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files         165      165           
  Lines        1325     1325           
  Branches      357      357           
=======================================
  Hits         1322     1322           
  Misses          2        2           
  Partials        1        1           

codecov-commenter avatar Aug 26 '24 13:08 codecov-commenter