feat(join): add join

[kim-sung-jee]

trafficstars

Description

add join function

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
es-toolkit	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 18, 2024 4:33pm

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.77%. Comparing base (010ec04) to head (015d5a8). Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files         161      162    +1     
  Lines        1323     1325    +2     
  Branches      357      358    +1     
=======================================
+ Hits         1320     1322    +2     
  Misses          2        2           
  Partials        1        1           

[dayongkr]

We already have a native api(Array.prototype.join), so I thinks that it needs only in es-toolkit/compat.

[kim-sung-jee]

I understand that, aside from src/compat, the es-toolkit does not support a join function. Does that seem correct?

[dayongkr]

You can see a same case in here(es-toolkit/compat/concat).

This function is only available in es-toolkit/compat for compatibility reasons. It either has alternative native JavaScript APIs or isn’t fully optimized yet.

I hope that this information is helpful.

[kim-sung-jee]

@dayongkr

oh thank you! I'll close the PR.

[dayongkr]

I think that you don't have to close this PR at now, it is just my opinion.

Maybe, you decide whether close or not after reviewing @raon0211.

Thanks!