es-toolkit icon indicating copy to clipboard operation
es-toolkit copied to clipboard

docs: fix Vercel deployment failures by async loading Sandpack component

Open kangju2000 opened this issue 1 year ago • 2 comments

This PR fixes Vercel deployment failures by implementing async loading for the Sandpack component in our vitepress theme config.

I believe the issue is caused by vitepress-plugin-sandpack's Sandbox component using DOM APIs on the server side. This change ensures Sandpack only loads client-side, preventing SSR-related errors.

We can't verify the fix in this PR as Vercel deployment doesn't run on PRs. We'll need to merge to confirm the solution works.

kangju2000 avatar Aug 08 '24 10:08 kangju2000

@kangju2000 is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Aug 08 '24 10:08 vercel[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.14%. Comparing base (d7247b8) to head (8a5a522).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         158      158           
  Lines        1163     1163           
  Branches      301      301           
=======================================
  Hits         1153     1153           
  Misses          9        9           
  Partials        1        1           

codecov-commenter avatar Aug 08 '24 11:08 codecov-commenter

Seems that it's not working, but I will open building docs in the pull request. Could you give it another try?

raon0211 avatar Aug 09 '24 02:08 raon0211