es-toolkit icon indicating copy to clipboard operation
es-toolkit copied to clipboard

feat(camelCase/capitalize/kebabCase/lowerCase/snakeCase/startCase): improve return types

Open D-Sketon opened this issue 1 year ago • 4 comments

Even though the type passes the test, I can't guarantee that it covers all boundary cases

D-Sketon avatar Jul 24 '24 15:07 D-Sketon

@D-Sketon is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jul 24 '24 15:07 vercel[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.57%. Comparing base (b3a04ef) to head (330f9fe).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         143      143           
  Lines         937      937           
  Branches      223      223           
=======================================
  Hits          933      933           
  Misses          4        4           

codecov-commenter avatar Jul 24 '24 15:07 codecov-commenter

close https://github.com/toss/es-toolkit/issues/172

D-Sketon avatar Jul 24 '24 15:07 D-Sketon

Hello, thanks for your contribution to our library! While I understand the reason of providing exact types, I am not sure they are worth it, considering maintainability and readability of complex types. Let me think a little bit about whether or not to include complex types to our library.

raon0211 avatar Jul 27 '24 03:07 raon0211

Hello, thanks for your contribution.

Since we value simplicity of the implementation, we decided not to merge complex types in our repository.

However, other types of contributions such as adding new functions would be really helpful for us. Looking forward to your next contribution.

raon0211 avatar Sep 13 '24 06:09 raon0211