torchlight-laravel icon indicating copy to clipboard operation
torchlight-laravel copied to clipboard

Laravel 11.x Compatibility

Open laravel-shift opened this issue 1 year ago • 5 comments

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

laravel-shift avatar Feb 27 '24 17:02 laravel-shift

:warning: The latest version of Laravel has a dependency for phpunit/phpunit of ^10.5. If you would like to also upgrade your tests, you may run the PHPUnit 10 Shift for free.

laravel-shift avatar Feb 27 '24 17:02 laravel-shift

:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.

laravel-shift avatar Feb 27 '24 17:02 laravel-shift

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/torchlight-laravel.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "torchlight/torchlight-laravel": "dev-l11-compatibility",
    }
}

Finally, run: composer update

laravel-shift avatar Feb 27 '24 17:02 laravel-shift

Are there any updates here?

ph7jack avatar Mar 28 '24 02:03 ph7jack

Please merge this..

valpuia604 avatar Apr 02 '24 08:04 valpuia604

What is the situation here? will this be merged?

I have been unsucessfull in using this fork

naykel76 avatar Apr 13 '24 23:04 naykel76

@aarondfrancis I'm certain you're very busy but it would be awesome if we could get this PR merged in. Don't intend to sound rude in the slightest but this package seems like it's been left to the wayside.

If you need an extra hand I'd be more than happy to help out with at least reviewing PR's. This is an awesome package and it would suck for it to be abandoned. Thanks!

miomech avatar Apr 16 '24 02:04 miomech

@aarondfrancis We're waiting for this PR merge.

dasundev avatar May 01 '24 15:05 dasundev

I tried the pull request locally and found that it works fine for me; I can see the highlights. This is my first time using Torchlight and I only tried x-torchlight-code blade compoent.

xuchunyang avatar May 10 '24 14:05 xuchunyang

Hello there. Plus one for this please. I just moved a customer over to the paid version of Torchlight. However development seems a bit stale unfortunately. We would love to update our project to Laravel 11 soon. Would appreciate an update. Thanks! 🙏

robdekort avatar May 11 '24 13:05 robdekort

Thanks for your patience!

aarondfrancis avatar May 16 '24 18:05 aarondfrancis

Amazing, thank you.

robdekort avatar May 16 '24 18:05 robdekort

Thank You!

miomech avatar May 16 '24 18:05 miomech