Derive ids from RTTI

Open dcodeIO opened this issue 5 years ago • 1 comments

This is a basic implementation of the suggestion made in https://github.com/torch2424/as-bind/issues/20, that is deriving the ids of the typed arrays from runtime type information instead of requiring the user to provide an additional entry file. Cornerstones are that the ids of ArrayBuffer, String and ArrayBufferView are fixed, and all the typed arrays have common properties in RTTI.

Leaving this as a draft for now, since it so far intentionally tries to touch as few code as possible to pass npm test. Let me know what you think :)

Feb 01 '20 16:02 dcodeIO

So after taking a look at your PR, it looks good! And I tested the code very thoroughly, so if it passes the tests. Should be good to go! Though I may re-architect some things if we go down this route, as the supported types could probably be simplified quite a bit :smile:

That being said though, before we move forward with this, I'd like to hear your response to my comment in #20 :+1:

Feb 04 '20 06:02 torch2424